Port validation and lifecycle fixes to Node, Python, and Go by stephentoub · Pull Request #1341 · github/copilot-sdk

stephentoub · 2026-05-20T03:07:07Z

C# recently tightened generated RPC argument validation and session lifecycle cleanup. This ports the commensurate behavior to the SDKs that had matching gaps so clients fail earlier, do not keep stale active sessions around, and reject duplicate active local sessions consistently.

Summary

Updates the TypeScript, Python, and Go RPC generators so generated session APIs validate required params before sending and reject session-scoped RPC calls after disconnect.
Cleans up Node, Python, and Go session/client lifecycle handling: direct disconnect unregisters from the parent client, stop/force-stop/delete paths clear active session maps safely, and duplicate active session IDs are rejected.
Adds focused lifecycle and generated-RPC regression coverage, plus adjusts Go e2e resume coverage for the new duplicate-active-session contract.

Rust was reviewed but left unchanged because its existing ownership/lifecycle model already covers the comparable behavior.

Validation

cd nodejs && npm run typecheck
cd nodejs && npm test -- client.test.ts --testNamePattern "directly disconnected|reports stop errors|replacement session|duplicate active|validates required"
cd python && python -m pytest -q test_client.py test_rpc_generated.py
cd python && python -m ruff check test_client.py test_rpc_generated.py copilot\client.py copilot\session.py
cd go && go test -timeout 20m ./...
git diff --check

Copilot

Pull request overview

This PR ports stricter generated-RPC argument validation and session lifecycle cleanup (previously tightened in C#) to the Node.js, Python, and Go SDKs, so clients fail earlier on invalid usage and don’t retain stale/duplicate active sessions.

Changes:

Updated TS/Python/Go RPC generators (and regenerated outputs) to validate required request objects before sending and to reject session-scoped RPC calls once a session is disconnected.
Hardened session/client lifecycle cleanup across Node/Python/Go (disconnect unregisters from the owning client; stop/force-stop/delete ensure sessions are marked unusable; duplicate active session IDs are rejected).
Added/updated targeted unit + E2E regression coverage to lock in lifecycle/validation behavior, including updated Go resume tests for the new “duplicate active session” contract.

Show a summary per file

File	Description
scripts/codegen/typescript.ts	Emit session “active” assertions and required-params checks in generated TS RPC methods.
scripts/codegen/python.ts	Emit session “active” assertions and required-params checks in generated Python RPC methods.
scripts/codegen/go.ts	Emit session “active” assertions and required-params checks in generated Go RPC methods.
python/test_rpc_generated.py	Adds regression tests for required-params validation and active-check behavior.
python/test_client.py	Adds/updates lifecycle tests for disconnect/unregister, duplicates, and failure cleanup paths.
python/copilot/session.py	Implements disconnect idempotency + active-use rejection; clears handlers/hooks on disconnect and supports unregister callback.
python/copilot/generated/rpc.py	Regenerated RPC surface with params validation and assert-active hooks for session APIs.
python/copilot/client.py	Adds session registration helpers; enforces duplicate-active rejection and consistent cleanup on stop/force-stop/delete.
nodejs/test/client.test.ts	Adds unit coverage for lifecycle cleanup, stop errors, duplicate registration, and params validation.
nodejs/src/session.ts	Adds disconnect state, active assertions, idempotent disconnect, forced-disconnect hook, and unregister callback.
nodejs/src/generated/rpc.ts	Regenerated RPC surface with params validation and assert-active hooks for session APIs.
nodejs/src/client.ts	Enforces duplicate-active session IDs; ensures stop/force-stop/delete mark sessions disconnected and clears internal RPC state.
go/session.go	Adds session active-state tracking, idempotent Disconnect, and client unregister on disconnect; rejects usage after disconnect.
go/session_test.go	Adds unit tests covering lifecycle cleanup and duplicate-active session registration behavior.
go/rpc/zrpc.go	Regenerated Go RPC surface with params validation and assert-active checks for session APIs.
go/rpc/generated_rpc_api_shape_test.go	Adds regression tests for required-params validation and active-check ordering.
go/internal/e2e/session_e2e_test.go	Updates E2E expectations for post-disconnect behavior and validates duplicate-active resume rejection; adds resume-client helper.
go/internal/e2e/session_config_e2e_test.go	Updates resume scenarios to use a separate TCP client consistent with the new “active session” contract.
go/internal/e2e/permissions_e2e_test.go	Updates resume permissions scenario to use separate resume client and aligns with new join behavior.
go/internal/e2e/mcp_and_agents_e2e_test.go	Updates resume scenarios to use separate resume client (TCP mode).
go/internal/e2e/commands_and_elicitation_e2e_test.go	Updates resume scenario to use separate resume client (TCP mode).
go/client.go	Enforces duplicate-active session IDs and centralizes session snapshot/clear helpers; ensures stop/force-stop disconnects and marks sessions unusable.

Copilot's findings

Files not reviewed (1)

go/rpc/zrpc.go: Language not supported

Files reviewed: 19/22 changed files
Comments generated: 2

github-actions

Generated by SDK Consistency Review Agent for issue #1341 · ● 2.6M

Port C# argument validation and lifecycle cleanup behavior to Node, Python, and Go. Generated session RPC APIs now validate required params and reject use after disconnect, while clients clean up active session maps consistently and reject duplicate active session IDs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Apply ruff formatting to the new Python lifecycle regression tests so CI format checks pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Mark Python test sessions inactive before same-client resume so the duplicate active-session guard is preserved without destroying the server-side session. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…rp-validation # Conflicts: # python/e2e/test_mcp_and_agents_e2e.py

github-actions · 2026-05-20T17:54:41Z

Cross-SDK Consistency Review ✅

This PR actively improves cross-SDK consistency — it ports validation and lifecycle behaviors from the .NET SDK (the reference implementation) to Node.js, Python, and Go.

What was verified

Feature	.NET	Node.js	Python	Go	Rust
Duplicate active session rejection	✅ pre-existing	✅ added	✅ added	✅ added	✅ ownership model
`unregisterSession` on direct disconnect	✅ pre-existing	✅ added	✅ added	✅ added	✅ ownership model
`markDisconnected` on client stop/force-stop	✅ pre-existing	✅ added	✅ added	✅ added	✅ ownership model
`assertActive` guard on RPC calls after disconnect	✅ `ThrowIfDisposed`	✅ added	✅ added	✅ added	✅ ownership model
`assertActive` in generated session RPC	✅ pre-existing	✅ added	✅ added	✅ added	✅ type system
Required-param null checks in generated RPC	✅ `ArgumentNullException.ThrowIfNull`	✅ TypeScript types	✅ Python types	✅ added nil-guards	✅ Rust types

Notes

.NET (Client.cs:1748–1756, Session.cs) had all these behaviors pre-existing; no changes needed.
Rust correctly left unchanged — the ownership/borrow-checker model enforces equivalent guarantees at compile time (no live reference can outlive the session handle).
The generated RPC files for Node, Python, and Go all include the assertActive callback plumbing (confirmed in rpc.ts, rpc.py, zrpc.go).
The stop() path fix (disconnect snapshot → clear map → mark remaining disconnected) is consistently implemented across all three modified SDKs.

No cross-SDK consistency gaps identified.

Generated by SDK Consistency Review Agent for issue #1341 · ● 1.3M · ◷

stephentoub requested a review from a team as a code owner May 20, 2026 03:07

Copilot AI review requested due to automatic review settings May 20, 2026 03:07

Copilot started reviewing on behalf of stephentoub May 20, 2026 03:07 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread python/copilot/session.py

Comment thread go/internal/e2e/permissions_e2e_test.go Outdated

This comment has been minimized.

Sign in to view

github-actions Bot reviewed May 20, 2026

View reviewed changes

Copilot AI added 3 commits May 20, 2026 08:38

Format Python lifecycle tests

30147cc

Apply ruff formatting to the new Python lifecycle regression tests so CI format checks pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix merge blockers after rebase

ce8aa9e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

stephentoub force-pushed the stephentoub/port-csharp-validation branch from bac3c1c to ce8aa9e Compare May 20, 2026 13:25

Guard Go event subscriptions after disconnect

a09710c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

Update generated RPC files after schema refresh

0baebaf

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

Fix Python same-client resume tests

7d6e120

Mark Python test sessions inactive before same-client resume so the duplicate active-session guard is preserved without destroying the server-side session. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into stephentoub/port-csha…

8fc2868

…rp-validation # Conflicts: # python/e2e/test_mcp_and_agents_e2e.py

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port validation and lifecycle fixes to Node, Python, and Go#1341

Port validation and lifecycle fixes to Node, Python, and Go#1341
stephentoub wants to merge 7 commits into
mainfrom
stephentoub/port-csharp-validation

stephentoub commented May 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot left a comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

stephentoub commented May 20, 2026

Summary

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented May 20, 2026

Cross-SDK Consistency Review ✅

What was verified

Notes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants